use listmode time frame for output frame definition if all events are used #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… throwing a warning otherwise
Co-authored-by: Kris Thielemans <[email protected]>
|
most jobs were ok, but one Also, clang-format issues. |
|
Can be reproduced by using the following .par file and which results in This is probably due to the fact that the |
|
The ROOT job worked fine, but I've cancelled the rest of the workflow as the merge commit will run everything again anyway. Hopefully that'll work ok. |
KrisThielemans
requested changes
Nov 18, 2024
documentation/release_6.3.htm
Outdated
| </li> | ||
| <li> | ||
| <tt>stir_timings</tt> has now an extra option to parse a par-file for a projector-pair. | ||
| </li> | ||
| <li> | ||
| Duration in sinogram interfile/exam_info obtained from lm_to_projdata has the correct value if we unlist all the events. This is not true for Root files | ||
| <a href=https://github.com/UCL/STIR/pull/1503>PR #1503</a> |
There was a problem hiding this comment.
This has to be 1519. Also, please use ROOT, use <tt>lm_to_projdata</tt> and put a <br> after that line.
KrisThielemans
approved these changes
Nov 19, 2024
KrisThielemans
changed the title
sure |
KrisThielemans
added a commit
to Dimitra-Kyriakopoulou/STIR
that referenced
this pull request
Nov 20, 2024
… used (UCL#1519) use the time frame information (where available) for the listmode data to set the frame definition for the output of LmToProjData if all events are used, issuing a warning otherwise --------- Co-authored-by: Kris Thielemans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use interfile information for frame difinition if all event are used,… throwing a warning otherwise
Changes in this pull request
use interfile information for frame difinition if all event are used,… throwing a warning otherwise
Testing performed
yes
Related issues
--fixes #1512
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)